Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(release-4.0.0) hds-2521: set focus on banner close #1429

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

NikoHelle
Copy link
Contributor

@NikoHelle NikoHelle commented Nov 19, 2024

Description

When banner is closed, the focus should be moved to given element.

Related Issue

Closes HDS-2521

Motivation and Context

How Has This Been Tested?

Added e2e tests

Demos:

Links to demos are in the comments

Screenshots (if appropriate):

Add to changelog

  • no need

Copy link

Preview found from hds-demo docs/preview_1429

Demos

Docs
Core Storybook
React Storybook

Copy link

github-actions bot commented Nov 19, 2024

Test Results

  1 files   64 suites   12m 2s ⏱️
 60 tests  60 ✅ 0 💤 0 ❌
120 runs  120 ✅ 0 💤 0 ❌

Results for commit 4616a52.

♻️ This comment has been updated with latest results.

The focus is moved to given element when banner closes on user action.
@NikoHelle NikoHelle force-pushed the hds-2521-focus-on-close branch from dbace63 to 4616a52 Compare November 20, 2024 07:08
Copy link
Contributor

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ship it!

@NikoHelle NikoHelle merged commit f774ce5 into release-4.0.0 Nov 20, 2024
8 checks passed
@NikoHelle NikoHelle deleted the hds-2521-focus-on-close branch November 20, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants